Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2574 Added show only encrypted emails filter buttoN #2642

Merged
merged 6 commits into from
Nov 8, 2024
Merged

#2574 Added show only encrypted emails filter buttoN #2642

merged 6 commits into from
Nov 8, 2024

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Nov 7, 2024 •
edited by sosnovsky
Loading

This PR added show only encrypted emails filter button

close #2574 // if this PR closes an issue

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review November 8, 2024 05:44
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner November 8, 2024 05:44
@ioanmo226 ioanmo226 requested a review from sosnovsky November 8, 2024 09:56
sosnovsky
sosnovsky reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now, thanks!

Just a minor UI issue - switch element seems to cropped by a couple pixles on the right side:

Screenshot 2024-11-08 at 14 49 50

@ioanmo226
Copy link
Collaborator Author

Fixed. Please check

sosnovsky
sosnovsky approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks!

@sosnovsky sosnovsky enabled auto-merge (squash) November 8, 2024 13:36
@sosnovsky sosnovsky merged commit 5be5b9a into master Nov 8, 2024
9 of 10 checks passed
@sosnovsky sosnovsky deleted the 2574-add-only-encrypted-emails-filter branch November 8, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "only encrypted emails" filter
2 participants
@ioanmo226 @sosnovsky